workbench: analysis updates #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deepfire
commented
Mar 4, 2023
deepfire
commented
- locli: cumulative announce metric, forger-side
- locli: earliest fetch metric
- locli: nomenclature improvements
- locli: allow diff-friendly output, by omitting processing/version timestamps
- locli: don't tag a past slot with a belated block number -- looks confusing (while technically correct)
- locli: fix the first-peer-notice metric to truly compute the earliest value, instead of being an average
- workbench: small fixes & quality-of-life improvements
deepfire
requested review from
a team,
mgmeier,
fmaste,
jutaro,
cleverca22,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
olgahryniuk
approved these changes
Mar 6, 2023
deepfire
force-pushed
the
bench-master
branch
2 times, most recently
from
82e81df
to
892ee7e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 9, 2023
4936: workbench: analysis updates r=deepfire a=deepfire 1. locli: cumulative announce metric, forger-side 1. locli: earliest fetch metric 1. locli: nomenclature improvements 1. locli: allow diff-friendly output, by omitting processing/version timestamps 1. locli: don't tag a past slot with a belated block number -- looks confusing (while technically correct) 1. locli: fix the first-peer-notice metric to truly compute the earliest value, instead of being an average 1. workbench: small fixes & quality-of-life improvements Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Required status check \"build-complete\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
angerman
approved these changes
Mar 9, 2023
| @@ -1,7 +1,6 @@ | |||
| {-# LANGUAGE StrictData #-} | |||
|
|
|||
| {-# LANGUAGE MultiWayIf #-} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.