Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and merge_group triggers in Github Actions #4942

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Create and merge_group triggers in Github Actions #4942

merged 1 commit into from
Mar 7, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Mar 6, 2023 •
edited
Loading

@newhoggy newhoggy force-pushed the newhoggy/create-and-merge_group-triggers-in-github-actions branch from 527fc73 to eac2eb4 Compare March 6, 2023 02:28
@newhoggy newhoggy marked this pull request as ready for review March 6, 2023 03:21
@newhoggy newhoggy requested review from Jimbo4350 and a team as code owners March 6, 2023 03:21
@newhoggy newhoggy enabled auto-merge March 6, 2023 03:21
@newhoggy newhoggy added this pull request to the merge queue Mar 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2023
angerman
angerman approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this looks good, as we don't need create with push?

@angerman angerman added this pull request to the merge queue Mar 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2023
@newhoggy newhoggy added this pull request to the merge queue Mar 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2023
Jimbo4350
Jimbo4350 reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the create trigger?

@Jimbo4350 Jimbo4350 self-requested a review March 6, 2023 13:35
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Mar 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2023
@newhoggy newhoggy added this pull request to the merge queue Mar 7, 2023
Merged via the queue into master with commit a3ccef4 Mar 7, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/create-and-merge_group-triggers-in-github-actions branch March 7, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@erikd erikd erikd approved these changes

@angerman angerman angerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newhoggy @angerman @erikd @Jimbo4350