Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In merge summary construct correct pr link #4991

Merged
merged 1 commit into from
Mar 17, 2023
Merged

In merge summary construct correct pr link #4991

merged 1 commit into from
Mar 17, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Mar 16, 2023 •
edited
Loading 

$ gen-merge-summary.sh [SINCE] [UNTIL]
Generate a merge summary between the SINCE and UNTIL date

Examples:
  gen-merge-summary.sh 2023-01-01 2023-01-08
  gen-merge-summary.sh 2023-01-01 '2023-01-01 +7 days'

Example output:

./scripts/gen-merge-summary.sh 2023-02-07 2023-02-14
# Merge summary for 2023-02-07 to 2023-02-14
- [workbench:  drop cabalWrapped](https://github.com/input-output-hk/cardano-node/pull/4873) (Kosyrev Serge)
- [workbench:  `make shell-nix` use Nix-built binaries](https://github.com/input-output-hk/cardano-node/pull/4872) (Kosyrev Serge)
- [Revert #4855](https://github.com/input-output-hk/cardano-node/pull/4870) (Jordan Millar)
- [Remove cardano-cli's dependency on cardano-node](https://github.com/input-output-hk/cardano-node/pull/4855) (Jordan Millar)

@newhoggy newhoggy force-pushed the newhoggy/in-merge-summary-construct-correct-pr-link branch from 8f62561 to 6dee647 Compare March 16, 2023 01:00
@newhoggy newhoggy marked this pull request as ready for review March 16, 2023 01:01
erikd
erikd approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is why is this two commits?

Otherwise LGTM.

@newhoggy newhoggy force-pushed the newhoggy/in-merge-summary-construct-correct-pr-link branch from 6dee647 to 49e7001 Compare March 16, 2023 01:16
@newhoggy newhoggy enabled auto-merge March 16, 2023 01:16
@newhoggy newhoggy added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2023
@newhoggy newhoggy added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2023
@newhoggy newhoggy force-pushed the newhoggy/in-merge-summary-construct-correct-pr-link branch from 49e7001 to f6ed708 Compare March 16, 2023 04:40
@newhoggy newhoggy enabled auto-merge March 16, 2023 04:40
@newhoggy newhoggy added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2023
@newhoggy newhoggy added this pull request to the merge queue Mar 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 16, 2023
@newhoggy newhoggy force-pushed the newhoggy/in-merge-summary-construct-correct-pr-link branch from f6ed708 to 77f31c5 Compare March 16, 2023 13:11
@newhoggy newhoggy added this pull request to the merge queue Mar 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2023
@newhoggy newhoggy added this pull request to the merge queue Mar 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2023
@newhoggy newhoggy force-pushed the newhoggy/in-merge-summary-construct-correct-pr-link branch from 77f31c5 to 630c46b Compare March 17, 2023 03:53
@newhoggy newhoggy enabled auto-merge March 17, 2023 03:56
@newhoggy newhoggy added this pull request to the merge queue Mar 17, 2023
Merged via the queue into master with commit d0b991f Mar 17, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/in-merge-summary-construct-correct-pr-link branch March 17, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikd erikd erikd approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhoggy @erikd