Expose UsingRawBytes et al types #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it simple to re-use de/serialisation for new types with DerivingVia. It is extensively used inside cardano-api and hence provides a clear value to users of the SDK as well.
ch1bo
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Apr 12, 2023
This should be rather taken from upstream. Created two PRs to avoid workarounds: IntersectMBO/cardano-node#5085 and IntersectMBO/cardano-node#5086
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Apr 14, 2023
This should be rather taken from upstream. Created two PRs to avoid workarounds: IntersectMBO/cardano-node#5085 and IntersectMBO/cardano-node#5086
newhoggy
approved these changes
Apr 15, 2023
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Apr 20, 2023
This should be rather taken from upstream. Created two PRs to avoid workarounds: IntersectMBO/cardano-node#5085 and IntersectMBO/cardano-node#5086
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Apr 22, 2023
This should be rather taken from upstream. Created two PRs to avoid workarounds: IntersectMBO/cardano-node#5085 and IntersectMBO/cardano-node#5086
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Apr 24, 2023
This should be rather taken from upstream. Created two PRs to avoid workarounds: IntersectMBO/cardano-node#5085 and IntersectMBO/cardano-node#5086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it simple to re-use de/serialisation for new types with DerivingVia. It is extensively used inside cardano-api and hence provides a clear value to users of the SDK as well.