Allow renamed fields to exist if values the same #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/allow-renamed-fields-to-exist-if-values-the-same
branch
from
65736fd
to
cbe3cb3
Compare
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
carbolymer
approved these changes
Apr 17, 2023
Jimbo4350
reviewed
Apr 17, 2023
|
|
||
| mOldValue <- v .:? "TestEnableDevelopmentNetworkProtocols" | ||
|
|
||
| forM_ mOldValue $ \_ -> do |
There was a problem hiding this comment.
why do we need forM_ here? Can't we just use when?
There was a problem hiding this comment.
yeah when (isJust mOldValue) should be the same
There was a problem hiding this comment.
Modified to use when.
newhoggy
force-pushed
the
newhoggy/allow-renamed-fields-to-exist-if-values-the-same
branch
from
cbe3cb3
to
88689d6
Compare
Jimbo4350
approved these changes
Apr 17, 2023
iohk-bors
bot
deleted the
newhoggy/allow-renamed-fields-to-exist-if-values-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow renamed fields to exist if the new field also exists and has the same value