New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error launching Git WebUI from Studio #297

Closed

isc-tleavitt opened this issue Dec 5, 2023 · 4 comments · Fixed by #298

Assignees

Labels

bug release blocker

Collaborator

isc-tleavitt commented Dec 5, 2023

isc-tleavitt added bug release blocker labels

isc-tleavitt assigned isc-pbarton

Collaborator Author

isc-tleavitt commented Dec 5, 2023

I think root cause is 8caa52a#diff-7ba949c5268466f0a1f9169a488b1b029ed288bd414a09562f8905074e402b47R328 - IE doesn't support includes(); see https://www.w3schools.com/Jsref/jsref_includes_array.asp

Collaborator Author

isc-tleavitt commented Dec 5, 2023

(we should add a polyfill)

Collaborator Author

isc-tleavitt commented Dec 5, 2023

https://stackoverflow.com/questions/53308396/how-to-polyfill-array-prototype-includes-for-ie8

isc-tleavitt assigned isc-tleavitt and unassigned isc-pbarton

Collaborator Author

isc-tleavitt commented Dec 5, 2023

Second issue is with named capture groups in parsing git branch output.

isc-tleavitt mentioned this issue

Fix JS bugs in Studio Git WebUI #298

Merged

isc-tleavitt closed this as completed in #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment