Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullEventHandler returns a Success Status even if an error was thrown during the process #300

Closed
isc-adepedro opened this issue Dec 7, 2023 · 2 comments
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@isc-adepedro
Copy link

SourceControl.Git.API:Pull output:

w ##class(SourceControl.Git.API).Pull()

Pulling from branch: test
Fetch done
Files that will be modified by git pull: 
    M.gitlab-ci.yml
    DHS.Local.Hospital.GetPatientInfoProcess.CLSsrc/HS/Local/Hospital/GetPatientInfoProcess.cls
Updating 409377f..48f9b3e
                         Fast-forward
                                      .gitlab-ci.yml                                  | 140 ++++++++++++------------
                                                                                                                     src/HS/Local/Hospital/GetPatientInfoProcess.cls |  48 --------
                                                           2 files changed, 70 insertions(+), 118 deletions(-)
                                                                                                               delete mode 100644 src/HS/Local/Hospital/GetPatientInfoProcess.cls


.gitlab-ci.yml was not imported into the database and will not be compiled. 
ERROR importingHS.Local.Hospital.GetPatientInfoProcess.CLS

ERROR #5012: File '/home/irisowner/confstream/hospital/src/HS/Local/Hospital/GetPatientInfoProcess.cls' does not exist
Compilation started on 12/07/2023 13:25:33 with qualifiers 'cukb'
Class HS.Local.Hospital.GetPatientInfoProcess is up-to-date.
Compilation finished successfully in 0.050s.
1

The return of the previous execution is 1

@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Dec 7, 2023
@isc-tleavitt isc-tleavitt added this to the Q1 2024 Polishing milestone Dec 7, 2023
@isc-tleavitt
Copy link
Collaborator

Might make sense to handle via the same PR as #299

@isc-tleavitt
Copy link
Collaborator

#320 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

No branches or pull requests

2 participants