Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix production conflict auto-resolve #526

Closed
isc-tleavitt opened this issue Oct 7, 2024 · 2 comments · Fixed by #574
Closed

Fix production conflict auto-resolve #526

isc-tleavitt opened this issue Oct 7, 2024 · 2 comments · Fixed by #574
Assignees
Labels
bug Something isn't working usability

Comments

@isc-tleavitt
Copy link
Collaborator

Example of merge conflict:

<<<<<<< src/HCC/Connect/Production.cls
  <Item Name="PreReleaseSample1" Category="" ClassName="EnsLib.MsgRouter.RoutingEngine" PoolSize="1" Enabled="false" Foreground="false" Comment="" LogTraceEvents="false" Schedule="">
    <Setting Target="Host" Name="BusinessRuleName">HCC.Foo.PrereleaseSample1</Setting>
=======
  <Item Name="PrereleaseTesting2" Category="" ClassName="EnsLib.HL7.Service.FileService" PoolSize="1" Enabled="false" Foreground="false" Comment="" LogTraceEvents="false" Schedule="">
>>>>>>> src/HCC/Connect/Production.cls
  </Item>

Should resolve to:

  <Item Name="PreReleaseSample1" Category="" ClassName="EnsLib.MsgRouter.RoutingEngine" PoolSize="1" Enabled="false" Foreground="false" Comment="" LogTraceEvents="false" Schedule="">
    <Setting Target="Host" Name="BusinessRuleName">HCC.Foo.PrereleaseSample1</Setting>
  </Item>
  <Item Name="PrereleaseTesting2" Category="" ClassName="EnsLib.HL7.Service.FileService" PoolSize="1" Enabled="false" Foreground="false" Comment="" LogTraceEvents="false" Schedule="">
  </Item>
@isc-tleavitt isc-tleavitt added enhancement New feature or request usability labels Oct 7, 2024
@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Oct 7, 2024
@isc-tleavitt isc-tleavitt self-assigned this Oct 23, 2024
@isc-tleavitt
Copy link
Collaborator Author

In some TDD I'm getting the merge resolved automatically in the example case, which is weird because it definitely errored along these lines in our HCC deployment.

@isc-tleavitt isc-tleavitt added bug Something isn't working and removed enhancement New feature or request labels Oct 24, 2024
@isc-tleavitt
Copy link
Collaborator Author

isc-tleavitt commented Oct 24, 2024

Oof - this is actually a larger bug in our production conflict auto-resolution, because we added sync output to the log and that's making it look like more than a simple conflict.

@isc-tleavitt isc-tleavitt changed the title Improve production conflict auto-resolve on items with settings Fix production conflict auto-resolve Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant