Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error handling when creating a new branch in basic mode #624

Closed
isc-pbarton opened this issue Nov 6, 2024 · 0 comments · Fixed by #625
Closed

Missing error handling when creating a new branch in basic mode #624

isc-pbarton opened this issue Nov 6, 2024 · 0 comments · Fixed by #625
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@isc-pbarton
Copy link
Collaborator

If I create a new branch in Basic Mode, and it fails to check out the default merge branch (for example because I have some uncommitted changes that conflict), it appears to succeed. A new branch is created off of my current branch instead of the default branch.

Then when I create a merge request to the default branch on my remote, my merge includes both my commits from the old branch and the new branch.

If we fail to checkout the default merge branch, we should display an error instead of creating a new branch.

@isc-pbarton isc-pbarton self-assigned this Nov 6, 2024
@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Nov 7, 2024
@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants