-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for git pull #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass - probably needs a bit more work around the use case where a CSP file changes. (Theory: call OnBeforeTimestamp / OnBeforeLoad at end of AfterUserAction if the name is mapped?)
Also tweaks some styling and fixes behavior for interop-enabled namespaces with a URLPrefix.
Also fixed an issue with regex matching where I couldn't view my local git-source-control repo
This got weirdly tangled with #464 - not sure why some commits are duplicated even after rebasing. |
Remote duplicated content
I'm going to change the target branch and change it back to see if that resolves GitHub showing duplicated commits |
isc-pbarton
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Git pull operations and pull event handlers also call UpdateProduction() when applicable.
Git pull output is more verbose and helpful, especially from the git pull package / websocket.
Git pull won't fail in some edge-ish cases (long filenames, unmapped files)
These reports all came from the same customer and are handy to test together, so grouping the fixes.
Fixes #467
Fixes #453
Fixes #457
Fixes #473