Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for git pull #476

Merged
merged 13 commits into from
Sep 13, 2024
Merged

Various fixes for git pull #476

merged 13 commits into from
Sep 13, 2024

Conversation

isc-tleavitt
Copy link
Collaborator

Summary:
Git pull operations and pull event handlers also call UpdateProduction() when applicable.
Git pull output is more verbose and helpful, especially from the git pull package / websocket.
Git pull won't fail in some edge-ish cases (long filenames, unmapped files)

These reports all came from the same customer and are handy to test together, so grouping the fixes.

Fixes #467
Fixes #453
Fixes #457
Fixes #473

First pass - probably needs a bit more work around the use case where a CSP file changes. (Theory: call OnBeforeTimestamp / OnBeforeLoad at end of AfterUserAction if the name is mapped?)
Also tweaks some styling and fixes behavior for interop-enabled namespaces with a URLPrefix.
Also fixed an issue with regex matching where I couldn't view my local git-source-control repo
@isc-tleavitt
Copy link
Collaborator Author

This got weirdly tangled with #464 - not sure why some commits are duplicated even after rebasing.

Remote duplicated content
@isc-pbarton
Copy link
Collaborator

I'm going to change the target branch and change it back to see if that resolves GitHub showing duplicated commits

@isc-pbarton isc-pbarton changed the base branch from main to workflow September 12, 2024 21:02
@isc-pbarton isc-pbarton changed the base branch from workflow to main September 12, 2024 21:03
@isc-tleavitt isc-tleavitt merged commit cedb88b into main Sep 13, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the fix-467-and-others branch September 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants