New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanent redirect pushing wrong status code? #242

Closed

adamgotterer opened this issue Sep 10, 2012 · 1 comment · Fixed by #243

Contributor

adamgotterer commented Sep 10, 2012

redirect 'http://www.github.com', :permanent => true

This will push a status of 304. Shouldn't the status be 301?

endpoint.rb:

      if merged_options[:permanent]
        status 304

Member

dblock commented Sep 10, 2012

Uhm, yes, that would be a problem.

adamgotterer mentioned this issue

Updates permanent redirect status code from 304 to 301 #243

Merged

dblock closed this as completed in

da52e8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment