adds 405 response for methods not supported on a resource instead of 404 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every resource an 'OPTIONS' route that returns an HTTP 204 response will be added. Also a route that will return an HTTP 405 response for any HTTP method that the resource cannot handle will be added. The behavior up to now has been to return an HTTP 404 response if the resource doesn't respond to the request's HTTP method.
|
This looks good - I'll leave it for comments for a bit. Can you please update the README and CHANGELOG? Also the build failed for what seems like an unrelated reason, but I could be wrong, check it out pls. |
|
No problem, I'll take care of it tomorrow. Thanks for being so responsive on pull requests. |
|
Thank you, merging. |
dblock
added a commit
that referenced
this pull request
Oct 2, 2012
adds 405 response for methods not supported on a resource instead of 404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every resource an 'OPTIONS' route that returns an HTTP 204 response will
be added. Also a route that will return an HTTP 405 response for
any HTTP method that the resource cannot handle will be added.
The behavior up to now has been to return an HTTP 404 response if the
resource doesn't respond to the request's HTTP method.