New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API simplification #22

Closed

5 tasks done

rofinn opened this issue Jul 4, 2019 · 0 comments

Milestone

Member

rofinn commented Jul 4, 2019 •

edited

Loading

Before we cut a 1.0 release we should simplify our public API to make maintaining this package easier. (Based off #17)

Deprecate impute(x, :method) in favour of Impute.method(x; kwargs...)
Imputors should contain the Context rather than passing that to impute
impute should always take an Imputor first
Impute.method(; kwargs) should return a function that takes the data
Deprecate chain as we should be able to use a more functional interface for now

The text was updated successfully, but these errors were encountered:

rofinn added this to the 1.0 milestone

rofinn mentioned this issue

Switch to Tables.jl API #20

Merged

2 tasks

rofinn closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment