-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): Adding default event parameters #5246
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DM1PTs437jDP8xcXjef2GuQpi75W |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks fantastic first shot. Thank you!
Github requires that a maintainer approves the CI runs on first contributions (to avoid PRs that just implement a cryptominer I think) - so I've done that and will wait for CI to go green
Looks like other than that you just need to follow the "Details" link on the failing CLA / license check and sign the license then we can merge this
Oh - now that CI has run it looks like some trivial formatting issues, and the jest error message isn't quite as expected as well as the CLA - waiting for those |
Codecov Report
@@ Coverage Diff @@
## master #5246 +/- ##
==========================================
+ Coverage 88.86% 88.87% +0.01%
==========================================
Files 109 109
Lines 3743 3746 +3
Branches 360 361 +1
==========================================
+ Hits 3326 3329 +3
Misses 370 370
Partials 47 47 |
Thanks for the tips. Done! |
Looks like there is still an issue with the CLA signing - I have had this happen before where I needed to add the email address as it mentions:
It appears to be looking for yoru max2fratane @ popular mail provider email address as that's the address in the commits on your fork |
E-mail added to my github account. |
Hey @MFrat - before I merge this, since it seemed like the iOS side had compile errors and couldn't have been checked - can you install the auto-generated patch-package format patches from CI and make sure they work in your project, with expected results on android and iOS? There is an artifacts link here that has them https://github.com/invertase/react-native-firebase/actions/runs/803147844 |
@mikehardy, I tested both in Android and iOS, with devices and simulator/emulator. Everything is working just fine. |
That's glorious :-), patch-package is such a beautiful thing. Thanks again for the PR here I'll merge it but hold for a few days prior to release in order to catch any other changes - you're set via patch-package until then though (it gives you a nice warning when you npm/yarn install after the package it has a patch for changes version so you'll know to clear the patch from source control later) |
Description
Adding feature for setting default event parameters. As described here in Firebase docs.
Release Summary
Added
setDefaultEventParameters
. It adds default event parameters that will be send in every event.Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter