-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android, emulator): add firebase.json config element to bypass localhost remap #5852
feat(android, emulator): add firebase.json config element to bypass localhost remap #5852
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4RdaowmCRKdFh6vMS6xQRpVDY7S4 react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/5QKerrqomXoxqoAeFUjqUaS6z912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you! The CI runs will produce a patch-package set that you may use immediately if you like, until this is released
We'll need the CLA signed though for sure - follow the details link there for more information if you haven't already signed it
Thanks again - I do like the toggle, I think the dev experience is better with the remapping but it's nice to not have it be mandatory
Codecov Report
@@ Coverage Diff @@
## main #5852 +/- ##
=============================================
- Coverage 72.41% 53.01% -19.40%
- Complexity 0 620 +620
=============================================
Files 109 208 +99
Lines 4534 10124 +5590
Branches 1003 1595 +592
=============================================
+ Hits 3283 5366 +2083
- Misses 1173 4503 +3330
- Partials 78 255 +177 |
Hey @stchristian - a gentle nudge to sign the CLA, if you follow the details link from the related comment it should walk you through it. Thanks! |
Something went wrong with the tests:ios:test-cover. Should I care about that? @mikehardy |
No, we're currently battling a nasty bit of flakiness from wix/Detox#3000 upstream, I've been re-starting it periodically, it will pass eventually. I have no doubt it's unrelated to this and will go green |
Also, where can I see the patch package that has been producer? |
They're linked off the action - should be able to see them here https://github.com/invertase/react-native-firebase/actions/runs/1464262461 |
boom! Thanks again |
Description
I came accross a problem with emulators and the way they are handling
localhost
addresses, described here.I would love to see this work with firebase emulators, when running and testing apps on real devices.
I started a discussion here
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter🔥