Fixes for handling of curvilinear coordinates #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
philippjfr
commented
Sep 26, 2018
•
philippjfr
commented
- Adds support for constructing curvilinear xarray dataset from literals
- Fixes bug where rasterization would flip QuadMesh
- Fixes bug where canonicalization would flip value dimension arrays when curvilinear coordinate arrays are used (this is unnecessary and caused various bugs)
This was referenced Sep 26, 2018
philippjfr
changed the title
philippjfr
added
type: bug
|
Ready to review and merge. |
philippjfr
force-pushed
the
qmesh_orientation_fixes
branch
from
9e43f97 to
e1c4526
Compare
philippjfr
force-pushed
the
qmesh_orientation_fixes
branch
from
e1c4526 to
f184182
Compare
philippjfr
force-pushed
the
qmesh_orientation_fixes
branch
from
4d95103 to
5926a87
Compare
|
Looks good and having a bunch more unit tests is comforting. As this PR is intended as a set of fixes only with no new features, I'll go ahead and merge. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.