Address categorical labels not responding to fontsizes #3047
Conversation
holoviews/plotting/bokeh/element.py
Outdated
| @@ -389,7 +395,12 @@ def _axis_properties(self, axis, key, plot, dimension=None, | |||
| Returns a dictionary of axis properties depending | |||
| on the specified axis. | |||
| """ | |||
| axis_props = {} | |||
| try: | |||
| axis_props = (built_in_themes[self.renderer.theme] | |||
There was a problem hiding this comment.
If we'll be doing this a lot maybe we should have a utility to get the default properties for a particular model type.
philippjfr
force-pushed
the
subcategorical_labels
branch
2 times, most recently
from
e84d17c to
836d4ad
Compare
|
Should I differentiate between major and group? If so, how should I approach it in the inputtable fontsize dictionary; major and minor ticks? |
That makes sense to me. |
|
Looks good to me, ready to merge? |
|
Sorry for changing my mind here but could you change this to a try/except after all? if bokeh_version <= '0.13.0':
built_in_themes = {}
else:
from bokeh.themes import built_in_themes |
philippjfr
force-pushed
the
subcategorical_labels
branch
from
775a558 to
0266201
Compare
|
Looks good to me. |
|
Okay, let's merge once tests are passing. |
|
One build had a transient and needed to be restarted but all the other builds are now green. I'll go ahead and merge. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#3007
Okay I think it's ready?
