Add ability to set active tools #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
reviewed
Dec 3, 2018
| @@ -39,6 +40,46 @@ | |||
| bokeh_version = LooseVersion(bokeh.__version__) # noqa | |||
|
|
|||
|
|
|||
| TOOL_TYPES = { | |||
There was a problem hiding this comment.
Shame we have to list the names like this. It would be good to get this from bokeh if possible. And if it isn't possible, I feel like this is information bokeh ought to provide...
There was a problem hiding this comment.
I prefer to list these explicitly, at least for now. In my next bokeh tool PR I might bring up adding this directly to bokeh.
philippjfr
force-pushed
the
active_tools
branch
2 times, most recently
from
de39bdd to
31cb6ee
Compare
philippjfr
force-pushed
the
active_tools
branch
from
31cb6ee to
2f41495
Compare
|
Very happy to finally be able to have this long requested feature! Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides control over the active tools on a plot via the
active_toolsoption which should be a list of tools that will be activated. The list can be specified as strings or as the tool instances being activated.Note that currently bokeh does not allow setting active tools for a merged toolbar, so for the option to work on a Layout or Grid the
merge_toolsoption has to be disabled.