Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added initial nightly-builder app #71

Merged
merged 3 commits into from
Apr 21, 2015
Merged

added initial nightly-builder app #71

merged 3 commits into from
Apr 21, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 11, 2015

Probably R=@Fishrock123 but input welcome from others.

This app is to be used via cron to trigger nightly builds for both nightly and next-nightly. It finds the latest build and gets the commit sha from it, then it compares that commit sha of the appropriate git branch (v1.x for nightly and next for next-nightly). If they don't match then it triggers a build on Jenkins using all the appropriate parameters for the iojs+release+nightly including an authorization token that's in the job configuration.

Used it just now to build https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/139/

@rvagg
Copy link
Member Author

rvagg commented Apr 11, 2015

probably needs readme ..

@cjihrig
Copy link
Contributor

cjihrig commented Apr 11, 2015

Thoughts on using the same coding style as node core?

@rvagg
Copy link
Member Author

rvagg commented Apr 11, 2015

running on iojs-www in /etc/crontab:

0 18    * * *   dist    node /home/dist/nightly-builder/ --type nightly --token redacted
0 19    * * *   dist    node /home/dist/nightly-builder/ --type next-nightly --token redacted

this server is running as UTC-4 (unfortunately)

@rvagg
Copy link
Member Author

rvagg commented Apr 11, 2015

Thoughts on using the same coding style as node core?

1cda5be0f1bc1ac709847305a1565c72__tumblr_inline_n0510cwkrd1r3yh7o

@cjihrig
Copy link
Contributor

cjihrig commented Apr 11, 2015

Sorry 😨

, post = qs.encode({
token : token
, json : JSON.stringify(data)
})

This comment was marked as off-topic.

@Fishrock123
Copy link
Contributor

Seems fine. Some style meh, but no big deal I suppose. Mostly just leftover nits.

@rvagg rvagg merged commit 310df1f into master Apr 21, 2015
@rvagg rvagg deleted the nightly-builder branch April 21, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants