-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: emit abort event from ClientRequest
ClientRequest will now emit an abort event the first time abort() is called. Semver: Minor Fixes: nodejs/node-v0.x-archive#9278 PR-URL: #945 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
- Loading branch information
Showing
3 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -859,6 +859,13 @@ Emitted when the server sends a '100 Continue' HTTP response, usually because | |
the request contained 'Expect: 100-continue'. This is an instruction that | ||
the client should send the request body. | ||
|
||
### Event: 'abort' | ||
|
||
`function () { }` | ||
|
||
Emitted when the request has been aborted by the client. This event is only | ||
emitted on the first call to `abort()`. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
evanlucas
Author
Contributor
|
||
|
||
### request.flush() | ||
|
||
Flush the request headers. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
var assert = require('assert'); | ||
var http = require('http'); | ||
var common = require('../common'); | ||
var server = http.createServer(function(req, res) { | ||
res.end(); | ||
}); | ||
var count = 0; | ||
server.listen(common.PORT, function() { | ||
var req = http.request({ | ||
port: common.PORT | ||
}, function() { | ||
assert(false, 'should not receive data'); | ||
}); | ||
|
||
req.on('abort', function() { | ||
// should only be emitted once | ||
count++; | ||
server.close(); | ||
}); | ||
|
||
req.end(); | ||
req.abort(); | ||
req.abort(); | ||
}); | ||
|
||
process.on('exit', function() { | ||
assert.equal(count, 1); | ||
}) |
@evanlucas this seems mixed to me - aborted by the client yet call to
abort()
? are we saying thatabort()
is only ever called as a result of an internal abort by the client?