-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
net: make Server.prototype.unref() persistent
Currently, the unref() method does not remember any state if called before the server's handle has been created. This commit adds state to track calls to ref() and unref(). PR-URL: #897 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
- Loading branch information
1 parent
26ebe98
commit d8eb974
Showing
2 changed files
with
29 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var net = require('net'); | ||
var closed = false; | ||
var server = net.createServer(); | ||
|
||
// unref before listening | ||
server.unref(); | ||
server.listen(); | ||
|
||
// If the timeout fires, that means the server held the event loop open | ||
// and the unref() was not persistent. Close the server and fail the test. | ||
setTimeout(function() { | ||
closed = true; | ||
server.close(); | ||
}, 1000).unref(); | ||
|
||
process.on('exit', function() { | ||
assert.strictEqual(closed, false, 'server should not hold loop open'); | ||
}); |