Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Authorise @Fishrock123 to create releases #1225

Closed
rvagg opened this issue Mar 21, 2015 · 16 comments
Closed

Proposal: Authorise @Fishrock123 to create releases #1225

rvagg opened this issue Mar 21, 2015 · 16 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Mar 21, 2015

@iojs/tc (and anyone else interested in commenting of course)

This is separate the question of Jeremiah on the TC. I actually intended to do this before he was even nominated to the TC by @mikeal simply because it'd be nice to have a broader group of releasers and neat to have someone not on the TC able to do this.

Currently there's myself and @chrisdickinson who are authorized to make releases. This authorization is both organisational (should have sign-off from the TC) and technical (needs GPG key on the README and ssh access to the website for the "dist" user).

We need more people able to make releases so we continue our cadence and not create bottlenecks or have a low bus-factor.

See https://github.com/iojs/io.js/blob/v1.x/doc/releases.md for how the release process works.

@chrisdickinson
Copy link
Contributor

I am +1 on this.

@benjamingr
Copy link
Member

Sure, sounds good :)

@bnoordhuis
Copy link
Member

No disagreement from me.

@trevnorris
Copy link
Contributor

cool

@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Mar 24, 2015
@piscisaureus
Copy link
Contributor

Since there is no tc meeting this week: +1 from me

@Fishrock123
Copy link
Contributor

fwiw I'm willing for this. :)

@bnoordhuis
Copy link
Member

Unanimously +1'd in today's TC meeting. I'll close the issue but feel free to reopen if it needs to stay open.

@rvagg
Copy link
Member Author

rvagg commented Apr 1, 2015

@Fishrock123 can you read https://github.com/iojs/io.js/blob/v1.x/doc/releases.md and then do the following:

  1. PR against README.md to add a PGP key fingerprint next to your name, make sure it's published and available as the doc says
  2. Tell me which is your primary SSH key @ https://github.com/Fishrock123.keys and I'll add that on the server and then you'll be set to go

@Fishrock123
Copy link
Contributor

Sure, I'll get this sorted out tomorrow.

@Fishrock123
Copy link
Contributor

I still need to sort out the SSH thing.

Turns out I haven't used any of the github SSH keys in quite some time; I've been using github's personal access tokens through credential.helper=osxkeychain.

@Fishrock123
Copy link
Contributor

Does it need to be accessible at https://github.com/Fishrock123.keys?

@Fishrock123
Copy link
Contributor

Also, the thing I upload to the sks keyserver for the gpg key should be this, right?

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

<snip>

-----END PGP PUBLIC KEY BLOCK-----

@bnoordhuis
Copy link
Member

Yes, it should be your public key.

@rvagg
Copy link
Member Author

rvagg commented Apr 3, 2015

@Fishrock123 re ssh key, just get me your pubkey somehow, if you don't want it on github then perhaps email it to me and sign it with your gpg key that's in the pool, or something

@Fishrock123
Copy link
Contributor

@rvagg it's the last (bottom) one on github now, ending in fImqwZn6NB

@rvagg
Copy link
Member Author

rvagg commented Apr 4, 2015

done, you should be able to tools/release.sh when your keys is on the README and it should look something like this:

$ tools/release.sh 
# Selecting GPG key ...
Using GPG key: 7D83545D
  Fingerprint: DD8F2338BAE7501E3DD5AC78C273792F7D83545D

# Checking for releases ...
No releases to promote!

Starefossen pushed a commit to Starefossen/docker-iojs that referenced this issue Apr 4, 2015
PR-URL: nodejs#48
Related: nodejs/node#1324
Related: nodejs/node#1225
Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

7 participants