doc: make tools/update-authors.sh cross-platform #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -723,5 +722,11 @@ Ryan Scheel <Ryan.havvy@gmail.com> | |||
| Benjamin Gruenbaum <inglor@gmail.com> | |||
| Pavel Medvedev <pmedvedev@gmail.com> | |||
| Russell Dempsey <sgtpooki@gmail.com> | |||
| &! (bitandbang) <tieliaco@gmail.com> | |||
| h7lin <i@h7lin.com> | |||
There was a problem hiding this comment.
I couldn't find real names for these two. :-/
There was a problem hiding this comment.
ping @bnb, got a name you want listed in AUTHORS?
|
sad, but close enough to the original, LGTM |
And by cross-platform I mean Linux and OS X. The awk script is not compatible with BSD awk, that's why this commit changes it to perl. Update the .mailmap to remove some duplicates and regenerate the AUTHORS file. Fixes: nodejs#1120 PR-URL: nodejs#1121 Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis
force-pushed
the
fix-update-authors
branch
from
dd6003f
to
d33a647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And by cross-platform I mean Linux and OS X. The awk script is not
compatible with BSD awk, that's why this commit changes it to perl.
Update the .mailmap to remove some duplicates and regenerate the
AUTHORS file.
Fixes: #1120
R=@rvagg