doc: minor typo in CHANGELOG.md #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
changelog-process-progress-derp
branch
2 times, most recently
from
9164435
to
472c291
Compare
|
updated to include the cipher suite changes notes by @silverwind also |
|
First line is fine, second should be: Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion |
rvagg
force-pushed
the
changelog-process-progress-derp
branch
from
472c291
to
da87915
Compare
|
@silverwind changed, ptal |
|
LGTM |
PR-URL: nodejs#902 Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
force-pushed
the
changelog-process-progress-derp
branch
from
da87915
to
0ac5731
Compare
|
ta muchly! |
This was referenced Feb 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@silverwind