src: fix intermittent SIGSEGV in resolveTxt #960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we upstreaming these or are we giving up on working with c-ares? |
|
Oh, sorry, this is the wrap. Ignore that comment then! LGTM and we can get this in 1.4.0. |
|
The following code reproduces the error with a well known site. Do you think it's worth adding this to the internet test suite? var dns = require('dns');
dns.resolveTxt('www.microsoft.com', function(err, res) {
console.log(err);
console.log(res);
}); |
|
@cjihrig probably .. it's simple enough and should probably go in test/internet |
|
k, ill add that |
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records`
evanlucas
force-pushed
the
dns-txt-fix
branch
from
4b18550
to
b59c1f2
Compare
|
Test has been added |
|
lgtm, land it |
evanlucas
added a commit
that referenced
this pull request
Feb 26, 2015
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` PR-URL: #960 Reviewed-By: Rod Vagg <rod@vagg.org>
|
Landed in e435a01 |
evanlucas
added a commit
to evanlucas/node-v0.x-archive
that referenced
this pull request
Feb 26, 2015
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` PR-URL: nodejs/node#960 Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a SIGSEGV by making sure
txt_chunkis not empty before settingit on
txt_recordsRef: nodejs/node-v0.x-archive#9285