Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: improve vcbuild.bat #998

Closed
wants to merge 1 commit into from
Closed

build: improve vcbuild.bat #998

wants to merge 1 commit into from

Conversation

piscisaureus
Copy link
Contributor

  • Support running multiple test suites (e.g. vcbuild test-simple test-gc).
  • Removed a nonexisting test suite (test-uv).
  • Removed superfluous extra layer of argument parsing.
  • Fix the node-weak build.

R=@rvagg

@piscisaureus
build: improve vcbuild.bat
f572e8f 
* Support running multiple test suites (e.g. vcbuild test-simple test-gc).
* Removed a nonexisting test suite (test-uv).
* Removed superfluous extra layer of argument parsing.
* Fix the node-weak build.

R=@rvagg
@piscisaureus piscisaureus mentioned this pull request Feb 28, 2015
Closed
@rvagg
Copy link
Member

rvagg commented Feb 28, 2015

yep, works, lgtm

piscisaureus added a commit that referenced this pull request Feb 28, 2015
@piscisaureus @rvagg
build: improve vcbuild.bat
25da074 
* Support running multiple test suites (e.g. vcbuild test-simple test-gc).
* Removed a nonexisting test suite (test-uv).
* Removed superfluous extra layer of argument parsing.
* Fix the node-weak build.

R=@rvagg

PR-URL: #998
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Feb 28, 2015

landed @ 25da074, I hope you don't mind me merging this

@rvagg rvagg closed this Feb 28, 2015
@rvagg rvagg mentioned this pull request Feb 28, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Apr 9, 2015
Closed
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @rvagg