Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

add target to the button "Github Org" #24

Closed
wants to merge 1 commit into from
Closed

add target to the button "Github Org" #24

wants to merge 1 commit into from

Conversation

italoacasas
Copy link

No description provided.

@Fishrock123
Copy link
Contributor

Hmmm. @mikeal do we want to open things in new tabs?

@italoacasas
Copy link
Author

@Fishrock123 all buttons open in a new tab, check the page.

@Fishrock123
Copy link
Contributor

Sure, but is this actually something we want? It gets a little silly on mobile.

@italoacasas
Copy link
Author

Ooo, anyway I think the biggest percentage of users are desk

@mikeal
Copy link
Contributor

mikeal commented Jan 12, 2015

Why this link and no others?

@italoacasas
Copy link
Author

The others are ready, I think this is forgotten

@therebelrobot
Copy link
Contributor

@snostorm @Fishrock123 et al.: should we close old PRs that can't be auto merged and have the original author fix it, or should we do something ourselves to fix it? I want to avoid a bunch of old forgotten PRs that can't be merged filling up our PR page.

@Fishrock123
Copy link
Contributor

@therebelrobot I'd say fix it ourselves if it's not much trouble. That's the policy I do from express.

The PR doesn't make much sense anymore, we don't do this anywhere ATM.

@italoacasas If you'd like to create a new PR for external-only links, that would be cool.

@snostorm
Copy link
Contributor

@therebelrobot I say we close after some sort of X day policy. First maybe tag the author to try and rebase/conflict resolve before closing? To me a close feels like a slight rejection.

I've been known to cherry-pick an easy change and just apply it myself, giving the original person git author credit. (Easier/quicker than the turnaround of waiting for them to fix.)

Let's add this to the agenda? (closing/fixing policy, not external links)

snostorm pushed a commit that referenced this pull request Feb 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants