fix(ios): correctly initialize cordova plugins with webViewEngine (#4039

)
ionic-team · Jan 12, 2021 · 273fab5 · 273fab5
1 parent 845bf48
commit 273fab5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ios/CapacitorCordova/CapacitorCordova/Classes/Public/CDVPlugin.h b/ios/CapacitorCordova/CapacitorCordova/Classes/Public/CDVPlugin.h
@@ -53,6 +53,7 @@ extern NSString* const CDVViewWillTransitionToSizeNotification;
 
 @interface CDVPlugin : NSObject {}
 
+- (instancetype)initWithWebViewEngine:(WKWebView *)theWebViewEngine;
 @property (nonatomic, weak) UIView* webView;
 @property (nonatomic, weak) WKWebView * webViewEngine;
 @property (nonatomic, strong) NSString * className;

diff --git a/ios/CapacitorCordova/CapacitorCordova/Classes/Public/CDVPluginManager.m b/ios/CapacitorCordova/CapacitorCordova/Classes/Public/CDVPluginManager.m
@@ -35,12 +35,12 @@ - (CDVPlugin *)getCommandInstance:(NSString*)pluginName
 
   id obj = [self.pluginObjects objectForKey:className];
   if (!obj) {
-    obj = [[NSClassFromString(className)alloc] init];
+    obj = [[NSClassFromString(className)alloc] initWithWebViewEngine: self.webView];
     if (!obj) {
       NSString* fullClassName = [NSString stringWithFormat:@"%@.%@",
                                  NSBundle.mainBundle.infoDictionary[@"CFBundleExecutable"],
                                  className];
-      obj = [[NSClassFromString(fullClassName)alloc] init];
+      obj = [[NSClassFromString(fullClassName)alloc] initWithWebViewEngine: self.webView];
     }
 
     if (obj != nil) {