Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): change native location accuracy values #2420

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

jcesarmobile
Copy link
Member

If enableHighAccuracy is set, use kCLLocationAccuracyBestForNavigation only for watchPosition() and kCLLocationAccuracyBest for getCurrentPosition()

If enableHighAccuracy is not set, use kCLLocationAccuracyThreeKilometers for fastest results.

closes #1893

@jcesarmobile jcesarmobile merged commit 16c3ea1 into ionic-team:master Feb 7, 2020
@jcesarmobile jcesarmobile deleted the ios-location branch February 7, 2020 13:53
priyankpat pushed a commit to priyankpat/capacitor that referenced this pull request Feb 13, 2020
chrisweight added a commit to chrisweight/capacitor that referenced this pull request Feb 17, 2020
* upstream/master: (50 commits)
  feat(Device): Add getBatteryInfo function (ionic-team#2435)
  fix(doctor): add electron checks (ionic-team#2434)
  chore(android): target SDK version 29 (ionic-team#2433)
  feat(android): update gradle and dependencies (ionic-team#2431)
  fix(ios): Make Clipboard plugin return errors (ionic-team#2430)
  feat(android): Handle onDestroy lifecycle event in plugins (ionic-team#2421)
  docs(ce-plugins): Remove or replace deprecated plugins (ionic-team#2419)
  feat(ios): change native location accuracy values (ionic-team#2420)
  docs(ce-guides): Remove dead link (ionic-team#2418)
  docs(network): Remove example guide because of dead link (ionic-team#2417)
  feat(electron): Remove injectCapacitor function (ionic-team#2415)
  fix(android): plugin retained events not being retained if listeners were empty (ionic-team#2408)
  chore(android): remove unused launch_splash.xml (ionic-team#2411)
  feat(Filesystem): Remove createIntermediateDirectories from MkdirOptions (ionic-team#2410)
  feat(android): use Fused Location Provider on Geolocation plugin (ionic-team#2409)
  fix(toast): unify duration across platforms (ionic-team#2340)
  feat(PushNotifications): Make register method return if permission was granted (ionic-team#2324)
  chore(circleci): update Xcode and remove install-cocoapods job (ionic-team#2402)
  chore(cli): fix tests for newer node versions (ionic-team#2403)
  fix(android): return original camera image if edition was canceled (ionic-team#2358)
  ...
@naranjamecanica
Copy link
Contributor

Any chance that this and #2409 will soon land in a 1.x release? Or is the 2.0 release imminent? 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geolocation on iOS is slow because it is always using high accuracy
2 participants