feat(android): use common variables for config and dependencies #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier for users to have common dependencies versions across Capacitor and its plugins and Cordova's plugins.
Also makes possible to configure the Capacitor SDK configurations so they can change them if desider.
For that it creates a new
variables.gradlewhere the capacitor dependencies versions and SDK configurations can be put.Changed capacitor android to use those dependencies and SDK configurations
Changed android-template to use those dependencies and SDK configurations
Changed plugin-template to use those dependencies and SDK configurations
Also, if new variables are introduced in the
variables.gradlefile and those variables were used by some cordova plugin, the variable won't be replaced by the default value inplugin.xml, so it uses the value invariables.gradleinstead.closes #447
closes #227
closes #732