fix(android) : App can crash on clipboard.read if empty #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrdnp
changed the title
jrdnp
changed the title
jcesarmobile
requested changes
Apr 29, 2020
android/capacitor/src/main/java/com/getcapacitor/plugin/Clipboard.java
Outdated
Show resolved
Hide resolved
jcesarmobile
changed the title
jcesarmobile
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered app crash when reading the content of the clipboard since 2.0.0+
It only occurs on Android platform and in my case on a Samsung with Android 7.
When my clipboard is empty (like after a reboot) and I attempt to read it, the plugin crashes the app because of a
NullPointerException.I checked the Android documentation and found the method hasPrimaryClip().
So I implemented it in order to check if the primary clip exists. If it's the case, normal behavior happen otherwise the clipboard content will be set to an empty string.