Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Splash.show not resolving if splash is visible #3262

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

sergiomilici
Copy link
Contributor

Fixes #3261 .

The issue was a check done: if the splash is visible, it was returning without completing the call.

@jcesarmobile jcesarmobile changed the title (android)Fix Splash.show not resolving promise if splash was visible fix(android): Splash.show not resolving if splash is visible Jul 15, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jcesarmobile jcesarmobile merged commit bfd9884 into ionic-team:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: (android) SplashScreen.show not resolving promise if splash is already being shown
2 participants