Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): auto detect framework's webDir #4550

Merged
merged 3 commits into from
May 18, 2021
Merged

feat(cli): auto detect framework's webDir #4550

merged 3 commits into from
May 18, 2021

Conversation

adamdbradley
Copy link
Contributor

Closes #4546

@adamdbradley
Copy link
Contributor Author

Takes a best guess, if it doesn’t figure it out then falls back to what it does today

@adamdbradley adamdbradley requested a review from elylucas May 7, 2021 19:19
@elylucas elylucas merged commit 329448a into main May 18, 2021
@elylucas elylucas deleted the detect-framework branch May 18, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasvidas thomasvidas thomasvidas approved these changes

@elylucas elylucas Awaiting requested review from elylucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Detect framework within cap init, set webDir from framework default
3 participants
@adamdbradley @thomasvidas @elylucas