feat(ios): Makes CapacitorBridge, WebViewAssetHandler, and WebViewDelegationHandler open classes, along with several of their methods #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebViewDelegationHandler open classes, along with several of their methods
Steven0351
requested review from
theproducer,
ItsChaceD,
giralte-ionic,
jcesarmobile,
markemer and
IT-MikeS
Steven0351
commented
Oct 20, 2023
| fileprivate(set) var webViewLoadingState = WebViewLoadingState.unloaded | ||
|
|
||
| private let handlerName = "bridge" | ||
|
|
||
| public init(bridge: CapacitorBridge? = nil) { |
There was a problem hiding this comment.
This initializer never would have respected the bridge passed in because it is set later in the CapacitorBridge initializer
markemer
approved these changes
Oct 23, 2023
jcesarmobile
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Changes look good, I've fixed some merge conflicts it had after the zoom feature PR.
But do we want to make all those classes and methods open @dallastjames?
giralte-ionic
approved these changes
Oct 30, 2023
|
Based on my swift understanding, it just makes subclassing and overriding these classes simpler for consumers and isn't really exposing any new public API, so I think we're good to do this. Also seems like Portals probably could really make use of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.