Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Specify keystore alias and alias password build options for apksigner #7073

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

bentleyo
Copy link
Contributor

There are two issues with how apksigner is called that have been identified in #7054.

  • If the keystore contains multiple keys the alias needs to be specified otherwise an error is thrown
  • If the key has a password the cli will hang as apksigner prompts input for the key password

We can get around this by specifying the required parameters for apksigner.

Copy link
Contributor

@theproducer theproducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since --ks-key-alias and --key-pass are optional, i'd rather signingArgs be built in a way to exclude those flags if they are not set.

@bentleyo
Copy link
Contributor Author

@theproducer I have updated the PR mate, are you happy with this approach?

@theproducer theproducer changed the title Specify keystore alias and alias password to fix #7054 fix: Specify keystore alias and alias password build options for apksigner Jan 2, 2024
@theproducer theproducer changed the title fix: Specify keystore alias and alias password build options for apksigner fix(cli): Specify keystore alias and alias password build options for apksigner Jan 2, 2024
@giralte-ionic giralte-ionic merged commit 6612c49 into ionic-team:main Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants