-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Specify keystore alias and alias password build options for apksigner #7073
Merged
giralte-ionic
merged 7 commits into
ionic-team:main
from
bentleyo:bugfix/apksigner-alias
Jan 3, 2024
Merged
fix(cli): Specify keystore alias and alias password build options for apksigner #7073
giralte-ionic
merged 7 commits into
ionic-team:main
from
bentleyo:bugfix/apksigner-alias
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markemer
requested review from
jcesarmobile,
theproducer,
ItsChaceD,
IT-MikeS,
giralte-ionic and
markemer
November 30, 2023 18:01
giralte-ionic
approved these changes
Dec 1, 2023
theproducer
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since --ks-key-alias
and --key-pass
are optional, i'd rather signingArgs
be built in a way to exclude those flags if they are not set.
@theproducer I have updated the PR mate, are you happy with this approach? |
theproducer
approved these changes
Jan 2, 2024
theproducer
changed the title
Specify keystore alias and alias password to fix #7054
fix: Specify keystore alias and alias password build options for apksigner
Jan 2, 2024
theproducer
changed the title
fix: Specify keystore alias and alias password build options for apksigner
fix(cli): Specify keystore alias and alias password build options for apksigner
Jan 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with how
apksigner
is called that have been identified in #7054.apksigner
prompts input for the key passwordWe can get around this by specifying the required parameters for
apksigner
.