-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): JSValueEncoder/Decoder feature parity with JSONEncoder/Decoder #7647
Conversation
implementations. The default implementation of URL encodes to/decodes from a dictionary, while Date by default encodes to/decodes from seconds since January 1, 2001. This implementation is similar to the method for handling dates and urls in Foundation.
This should partially address #7576 |
with JSONEncoder and JSONDecoder
After considering #7576 I think it makes sense for this PR to address the overall feature disparity between JSONEncoder/Decoder and JSValueEncoder/Decoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. I mean but I the fact we need to do it is Apple's fault, but given our options this is the way, I think.
The default implementation of URL encodes to/decodes from a dictionary, while Date by default encodes to/decodes from seconds since January 1, 2001.
This implementation is similar to the method for handling dates and urls in Foundation.