Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): JSValueEncoder/Decoder feature parity with JSONEncoder/Decoder #7647

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

Steven0351
Copy link
Member

@Steven0351 Steven0351 commented Sep 6, 2024

The default implementation of URL encodes to/decodes from a dictionary, while Date by default encodes to/decodes from seconds since January 1, 2001.

This implementation is similar to the method for handling dates and urls in Foundation.

implementations.
The default implementation of URL encodes to/decodes from a dictionary,
while Date by default encodes to/decodes from seconds since January 1,
  2001.
This implementation is similar to the method for handling dates and urls
in Foundation.
@Steven0351
Copy link
Member Author

This should partially address #7576

@Steven0351 Steven0351 changed the title fix(ios): Addresses Date and URL issues present in current Encoder and Decoder implementations fix(ios): JSValueEncoder/Decoder feature parity with JSONEncoder/Decoder Sep 6, 2024
@Steven0351
Copy link
Member Author

After considering #7576 I think it makes sense for this PR to address the overall feature disparity between JSONEncoder/Decoder and JSValueEncoder/Decoder

@Steven0351 Steven0351 changed the title fix(ios): JSValueEncoder/Decoder feature parity with JSONEncoder/Decoder feat(ios): JSValueEncoder/Decoder feature parity with JSONEncoder/Decoder Sep 7, 2024
Copy link
Member

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I mean but I the fact we need to do it is Apple's fault, but given our options this is the way, I think.

@Steven0351 Steven0351 merged commit 410249b into main Sep 12, 2024
6 checks passed
@Steven0351 Steven0351 deleted the codable-date-and-url-fixes branch September 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants