Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No nested property on Slides Component #10192

Closed
Artfloriani opened this issue Jan 26, 2017 · 10 comments
Closed

No nested property on Slides Component #10192

Artfloriani opened this issue Jan 26, 2017 · 10 comments

Comments

@Artfloriani
Copy link
Contributor

Artfloriani commented Jan 26, 2017

I am recreating this issue as it was closed as I might not have explained it well and it was not solved.
Original issue: #10191

Ionic version:
[ ] 1.x
[x] 2.x

I'm submitting a ...
[x] bug report

Current behavior:
After the Slides component was changed on Ionic RC.5, the nested parameter is not available on the Slides component even when using the Advanced options. The nested parameter is not available on the Slides.ts

Expected behavior:
Expose nested Slides parameter as an advanced option.

Ionic info:

Cordova CLI: 6.5.0
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.1
Xcode version: Not installed
@jgw96
Copy link
Contributor

jgw96 commented Jan 26, 2017

Ahh sorry about that @Artfloriani , my fault and thanks for reopening! We will take a look into this.

@Artfloriani
Copy link
Contributor Author

Is there any temporary workaround for this?

@jgw96
Copy link
Contributor

jgw96 commented Jan 26, 2017

Sorry but at the moment there isnt, we would have to add this feature back. I will make sure to bring this up with the team as we decide on what issues should be added to the next milestone.
Disclaimer: This is not a guarantee that it will be added to the next milestone but it will be considered (:

@jgw96 jgw96 self-assigned this Jan 26, 2017
@Artfloriani
Copy link
Contributor Author

Artfloriani commented Jan 26, 2017

If I manually edit the Slides.ts just to include this parameter would this work? Or is there a deep magic happening to bind the options with the Swipper API?

@mhartington
Copy link
Contributor

It's a bit more than just adding the nested property. Looking at swipers original codebase, there's a lot of logic in the internals that check for nested slides, so we'd have to go back and add that functionality

@jgw96 jgw96 removed their assignment Feb 3, 2017
@darron1217
Copy link

@jgw96 @mhartington
I also really need this feature...

What I'm planning to make is... (http://idangero.us/swiper/)
nested_slide

But I'm stuck here...
nested_slide_mine

Any workaround would be appreciated :)

@snortblt
Copy link

+1. Looking for vertical Slides within a horizontal one.

@gsimonpotla
Copy link

Hi, would there be any update or workaround or at least ETA for this regression ?

@gitmyhub
Copy link

Hi...I need to add vertical slides within a horizontal slide which is possible using nesting with swiper API. Could you please let us know if this is going to be added?

@ionitron-bot
Copy link

ionitron-bot bot commented Aug 15, 2018

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Aug 15, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants