Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-item-sliding problems in beta10 #7094

Closed
mpaland opened this issue Jun 28, 2016 · 4 comments
Closed

bug: ion-item-sliding problems in beta10 #7094

mpaland opened this issue Jun 28, 2016 · 4 comments
Assignees
Labels
needs: reply the issue needs a response from the user

Comments

@mpaland
Copy link

mpaland commented Jun 28, 2016

Type: bug

Ionic Version: 2.x

Platform: desktop browser

After upgrading to v2.beta10 using ios theme, the <ion-item-sliding> has two big problems:

  1. Using <ion-item-sliding> in a virtual list is extremely unresponsive and laggy. I guess event handlers from the virtual list disturb the sliding event handlers.
    Using <ion-item-sliding> in a 'normal' list is fine!
    I tested this in Edge and FF47 browser. This was okay in beta.9.
  2. When the sliding buttons are open, a click on the item closed the buttons.
    This is broken. Clicking on the item doesn't open the item nor closes the slider.
<ion-list [virtualScroll]="items">
  <ion-item-sliding *virtualItem="let item">
    <button ion-item detail-none (click)="onDetail(item)">
      <ion-thumbnail item-left>
        <img [src]="'item.photo" [style.height.rem]="5.6">
      </ion-thumbnail>
    </button>
    <ion-item-options>
      <button>
        <ion-icon name="text"></ion-icon>
        Test
      </button>
      <button secondary>
        <ion-icon name="call"></ion-icon>
        Call
      </button>
    </ion-item-options>
  </ion-item-sliding>
</ion-list>
@mpaland
Copy link
Author

mpaland commented Jun 28, 2016

The item sliding is extremely unresponsive on my real Android 6.0 device, too.

This seems to affect all platforms, please remove the 'ios' and 'range' label and add 'list'

@jgw96
Copy link
Contributor

jgw96 commented Jun 28, 2016

Hello, thanks for opening an issue with us! Would you be able to provide a plunker or repo that we can use to reproduce this issue please? Thanks!

@jgw96 jgw96 added needs: reply the issue needs a response from the user virtualscroll labels Jun 28, 2016
@manucorporat
Copy link
Contributor

manucorporat commented Jun 28, 2016

@jgw96 @mpaland don't worry I am aware of this issues. There are not easily fixable without breaking stuff. I have to continue thinking. I meant the issue 2

When the sliding buttons are open, a click on the item closed the buttons.
This is broken. Clicking on the item doesn't open the item nor closes the slider.

@manucorporat
Copy link
Contributor

@mpaland issue 2 should be fixed! please, can you open a new issue only with the first issue?

Using in a virtual list is extremely unresponsive and laggy. I guess event handlers from the virtual list disturb the sliding event handlers.
Using in a 'normal' list is fine!
I tested this in Edge and FF47 browser. This was okay in beta.9.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

4 participants