Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic2 - bug(searchbar) - Cancel button always shows when [animated]="true" #8903

Closed
zakton5 opened this issue Oct 25, 2016 · 7 comments
Closed
Assignees

Comments

@zakton5
Copy link
Contributor

zakton5 commented Oct 25, 2016

Short description of the problem:

The cancel button next to the searchbar is always shown when settings animated = true, despite showCancelButton being set to false by default.

What behavior are you expecting?

I expect the the cancel button to be hidden by default, as described in the docs, even when animated = true

@manucorporat
Copy link
Contributor

Can't reproduce it...

@zakton5
Copy link
Contributor Author

zakton5 commented Oct 26, 2016

Hm. I'll take another look

@Vlaai
Copy link

Vlaai commented Oct 26, 2016

I can confirm this issue in RC2

@zakton5
Copy link
Contributor Author

zakton5 commented Oct 27, 2016

Yeah, I am still having this issue, but I am using RC1. It happens regardless of where I place the searchbar (content or header)

@manucorporat
Copy link
Contributor

@zakton5 @JeroendeVin please provide some source code / screenshot / animated gif. I am not seeing anything unexpected.

@zakton5
Copy link
Contributor Author

zakton5 commented Nov 7, 2016

This GIF is with the following code:

<ion-searchbar [(ngModel)]="searchText" [placeholder]="'Search'" [animated]="true" [showCancelButton]="false" (ionInput)="filter()" (ionCancel)="cancelSearch()"></ion-searchbar>

ionic2_animated_searchbar

Setting animated to false hides the cancel button correctly.

@manucorporat
Copy link
Contributor

@zakton5 @JeroendeVin fixed!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants