fix(secure-storage): method is inaccessible when device is not secure #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d is inaccessible when device is not secure
danielsogl
approved these changes
Feb 22, 2020
danielsogl
changed the title
danielsogl
approved these changes
Feb 22, 2020
danielsogl
added
the
target: patch
This was referenced Mar 15, 2020
This was referenced Apr 3, 2020
Closed
danielzen
added a commit
to danielzen/ionic-native
that referenced
this pull request
May 11, 2020
danielsogl
pushed a commit
that referenced
this pull request
May 15, 2020
danielsogl
pushed a commit
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SecureStorage.create() method return SecureStorageObject only when the storage is secure, but we need SecureStorageObject to call secureDevice method and redirect the user to the secure device options.
Here a simple fix that riflects the cordova-plugin-storage-echo strategy.
fixes: #2486