fix(navigation): fixed nodes leak when opening and closing modals

ionic-team/ionic-framework#12574 (comment)
ionic-team · Mar 12, 2019 · b0426a3 · b0426a3
1 parent ee3d5f5
commit b0426a3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/navigation/view-controller.ts b/src/navigation/view-controller.ts
@@ -47,6 +47,7 @@ export class ViewController {
   _state: number = STATE_NEW;
   _cssClass: string;
   _ts: number;
+  _bindHandler: any;
 
   /**
    * Observable to be subscribed to when the current component will become active
@@ -113,7 +114,8 @@ export class ViewController {
 
     this._cssClass = rootCssClass;
     this._ts = Date.now();
-    window.addEventListener('orientationchange', this.handleOrientationChange.bind(this));
+    this._bindHandler = this.handleOrientationChange.bind(this);
+    window.addEventListener('orientationchange', this._bindHandler);
   }
 
   handleOrientationChange() {
@@ -542,7 +544,7 @@ export class ViewController {
         renderer.setElementAttribute(cmpEle, 'style', null);
       }
 
-      window.removeEventListener('orientationchange', this.handleOrientationChange.bind(this));
+      window.removeEventListener('orientationchange', this._bindHandler);
       // completely destroy this component. boom.
       this._cmp.destroy();
     }