Skip to content

Commit

Permalink
fix(app): add status bar padding to navbar when a tab subpage
Browse files Browse the repository at this point in the history
closes #6368
  • Loading branch information
brandyscarney committed May 2, 2016
1 parent e9d027b commit 62b97ce
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ionic/components/app/test/cordova/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class Page1 {
templateUrl: 'page2.html'
})
class Page2 {
page1 = Page1;
page3 = Page3;

constructor(private nav: NavController) {
Expand Down Expand Up @@ -122,7 +123,9 @@ class TabsPage {

@App({
templateUrl: `./app.html`,
config: { statusbarPadding: true }
config: {
statusbarPadding: true
}
})
class E2EApp {
root = Page1;
Expand Down
1 change: 1 addition & 0 deletions ionic/components/app/test/cordova/page2.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<ion-content padding>
<div padding-bottom>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Morbi scelerisque dolor lacus, ut vehicula arcu dapibus id. Morbi iaculis fermentum blandit. Curabitur tempus, ante et vehicula tempor, urna velit rutrum massa, quis suscipit purus lacus eget est. Sed nisi nulla, tempus id dictum a, cursus ut felis. Aliquam orci magna, rutrum nec tempor ac, fermentum quis eros. Sed ullamcorper felis sit amet tristique sagittis. Nullam sed tempus mi. Morbi sit amet lacinia leo. Nunc facilisis orci id consectetur dignissim. Integer dictum consectetur enim. Vivamus auctor, turpis ut eleifend pharetra, purus magna mattis arcu, vel pharetra tellus orci eget ex. Integer blandit posuere vehicula. Ut ipsum lorem, efficitur vitae eleifend tincidunt, fermentum nec lacus. Ut nec fermentum dui.</div>

<button block [navPush]="page1">Go to Page 1</button>
<button block [navPush]="page3">Go to Page 3</button>
<button block secondary (click)="openModal()" class="e2eCordovaOpenModal">Open Modal</button>
</ion-content>
1 change: 1 addition & 0 deletions ionic/platform/cordova.ios.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ ion-navbar-section.statusbar-padding > .toolbar {
min-height: calc(#{$toolbar-ios-height} + #{$cordova-ios-statusbar-padding});
}

.tab-subpage,
ion-nav > ion-page,
ion-menu {
> .toolbar.statusbar-padding:first-child ion-segment,
Expand Down
1 change: 1 addition & 0 deletions ionic/platform/cordova.md.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ ion-navbar-section.statusbar-padding > .toolbar {
min-height: calc(#{$toolbar-md-height} + #{$cordova-ios-statusbar-padding});
}

.tab-subpage,
ion-nav > ion-page,
ion-menu {
> .toolbar.statusbar-padding:first-child {
Expand Down
1 change: 1 addition & 0 deletions ionic/platform/cordova.wp.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ ion-navbar-section.statusbar-padding > .toolbar {
min-height: calc(#{$toolbar-wp-height} + #{$cordova-ios-statusbar-padding});
}

.tab-subpage,
ion-nav > ion-page,
ion-menu {
> .toolbar.statusbar-padding:first-child {
Expand Down

0 comments on commit 62b97ce

Please sign in to comment.