Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform is fix #10292

Merged
merged 2 commits into from
Feb 2, 2017
Merged

Platform is fix #10292

merged 2 commits into from
Feb 2, 2017

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Feb 2, 2017

Short description of what this resolves:

UiWebView on an iPad pro has a bug where it has an iPhone user agent: https://forums.developer.apple.com/thread/25948 . The good thing is that navigator.platform correctly returns iPad so we can use that to detect when the user is on an iPad pro.

Changes proposed in this pull request:

  • add extra check for iPad pro
  • add a unit test to prove it works

Ionic Version: 2.x

Fixes: #10209

@jgw96 jgw96 requested a review from brandyscarney February 2, 2017 20:48
@jgw96 jgw96 added this to the 2.0.1 milestone Feb 2, 2017
@brandyscarney brandyscarney merged commit f12fc61 into master Feb 2, 2017
@brandyscarney brandyscarney deleted the platformIsFix branch February 2, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney Awaiting requested review from brandyscarney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jgw96 @brandyscarney