Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-refresher is broken in latest nightly #10652

Closed
Sh1d0w opened this issue Mar 5, 2017 · 6 comments
Closed

ion-refresher is broken in latest nightly #10652

Sh1d0w opened this issue Mar 5, 2017 · 6 comments
Assignees
Milestone

Comments

@Sh1d0w
Copy link

Sh1d0w commented Mar 5, 2017

Ionic version: (check one with "x")
[ ] 1.x
[ x ] 2.x

I'm submitting a ... (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:

Using latest ionic-angular nightly (after update of angular version to 2.4.8) using ion-refresher components the page breaks with the error:

error_handler.js:60 TypeError: Cannot read property 'push' of null
    at UIEventManager.pointerEvents (ui-event-manager.js:22)
    at Refresher._setListeners (refresher.js:408)
    at Refresher.ngOnInit (refresher.js:423)
    at Wrapper_Refresher.ngDoCheck (/IonicModule/Refresher/wrapper.ngfactory.js:79)
    at DebugAppView.View_MonthReviewPage0.detectChangesInternal (/PagesModule/MonthReviewPage/component.ngfactory.js:859)
    at DebugAppView.AppView.detectChanges (view.js:425)
    at DebugAppView.detectChanges (view.js:620)
    at DebugAppView.AppView.internalDetectChanges (view.js:410)
    at DebugAppView.View_MonthReviewPage_Host0.detectChangesInternal (/PagesModule/MonthReviewPage/host.ngfactory.js:29)
    at DebugAppView.AppView.detectChanges (view.js:425)

Expected behavior:

The page should not break

Steps to reproduce:

  1. npm install ionic-angular@nightly

Related code:

<ion-content>

  <ion-refresher (ionStart)="doStart($event)" (ionPull)="doPulling($event)" (ionRefresh)="doRefresh($event)">

    <ion-refresher-content
      pullingText="Pull to refresh..."
      refreshingSpinner="bubbles"
      refreshingText="Refreshing...">
    </ion-refresher-content>

  </ion-refresher>

  <ion-list>
    <ion-item *ngFor="let item of items">
      {{ item }}
    </ion-item>
  </ion-list>

</ion-content>

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Your system information:

Cordova CLI: 6.4.0 
Ionic Framework Version: 2.1.0-201703032024
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.0 
ios-sim version: 5.0.13 
OS: macOS Sierra
Node Version: v7.7.1
Xcode version: Xcode 8.2.1 Build version 8C1002
@manucorporat manucorporat self-assigned this Mar 5, 2017
@manucorporat manucorporat added the v2 label Mar 5, 2017
@manucorporat manucorporat added this to the 2.2.0 milestone Mar 5, 2017
@manucorporat
Copy link
Contributor

Fixed! thanks @Sh1d0w

@Sh1d0w
Copy link
Author

Sh1d0w commented Mar 5, 2017

@manucorporat Thanks for the quick fix. Unfortunately it still breaks the page, now with another error:

TypeError: Cannot read property 'forEach' of null
    at UIEventManager.unlistenAll (ui-event-manager.js:33)
    at Refresher._setListeners (refresher.js:405)
    at Refresher.ngOnDestroy (refresher.js:431)
    at Wrapper_Refresher.ngOnDestroy (/IonicModule/Refresher/wrapper.ngfactory.js:20)
    at CompiledTemplate.proxyViewClass.View_MonthReviewPage0.destroyInternal (/PagesModule/MonthReviewPage/component.ngfactory.js:1114)
    at CompiledTemplate.proxyViewClass.AppView.destroy (view.js:203)
    at CompiledTemplate.proxyViewClass.DebugAppView.destroy (view.js:606)
    at CompiledTemplate.proxyViewClass.View_MonthReviewPage_Host0.destroyInternal (/PagesModule/MonthReviewPage/host.ngfactory.js:33)
    at CompiledTemplate.proxyViewClass.AppView.destroy (view.js:203)
    at CompiledTemplate.proxyViewClass.DebugAppView.destroy (view.js:606)
    at s (polyfills.js:3)
    at polyfills.js:3
    at t.invokeTask (polyfills.js:3)
    at Object.onInvokeTask (ng_zone.js:264)
    at t.invokeTask (polyfills.js:3)
    at e.runTask (polyfills.js:3)
    at i (polyfills.js:3)
    at HTMLButtonElement.invoke (polyfills.js:3)
(anonymous) @ ion-dev.js?v=1.1.4:156
ErrorHandler.handleError @ error_handler.js:60
IonicErrorHandler.handleError @ ionic-error-handler.js:56
next @ application_ref.js:348
schedulerFn @ async.js:93
SafeSubscriber.__tryOrUnsub @ Subscriber.js:223
SafeSubscriber.next @ Subscriber.js:172
Subscriber._next @ Subscriber.js:125
Subscriber.next @ Subscriber.js:89
Subject.next @ Subject.js:55
EventEmitter.emit @ async.js:79
NgZone.triggerError @ ng_zone.js:333
onHandleError @ ng_zone.js:294
t.handleError @ polyfills.js:3
e.runGuarded @ polyfills.js:3
r @ polyfills.js:3
i @ polyfills.js:3
invoke @ polyfills.js:3

@manucorporat
Copy link
Contributor

Sorry @Sh1d0w, my fault. I pushed the change without actually testing it :)

@ARHANIZAR
Copy link

ARHANIZAR commented Mar 14, 2017

I have the same problem here

error_handler.js:60 TypeError: Cannot read property 'push' of null
    at UIEventManager.pointerEvents (ui-event-manager.js:22)
    at Refresher._setListeners (refresher.js:408)
    at Refresher.ngOnInit (refresher.js:423)
    at Wrapper_Refresher.ngDoCheck (/IonicModule/Refresher/wrapper.ngfactory.js:79)
    at DebugAppView.View_MonthReviewPage0.detectChangesInternal (/PagesModule/MonthReviewPage/component.ngfactory.js:859)
    at DebugAppView.AppView.detectChanges (view.js:425)
    at DebugAppView.detectChanges (view.js:620)
    at DebugAppView.AppView.internalDetectChanges (view.js:410)
    at DebugAppView.View_MonthReviewPage_Host0.detectChangesInternal (/PagesModule/MonthReviewPage/host.ngfactory.js:29)
    at DebugAppView.AppView.detectChanges (view.js:425)

@Sh1d0w
Copy link
Author

Sh1d0w commented Mar 14, 2017

@ARHANIZAR This was fixed. Please updated to the latest version.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants