fix(rtl): add correct text-align #11353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandyscarney LGTM! |
|
@AmitMY @manucorporat The code itself looks great! I just want to test it real quick to make sure nothing broke. :) |
manucorporat
reviewed
May 1, 2017
src/themes/ionic.functions.scss
Outdated
|
|
||
| // Sets correct text align with support for old browsers | ||
| // @param {string} $direction - text direction | ||
| // @param {string} $decorator - !default, !important |
There was a problem hiding this comment.
I think !default is just a SCSS thing, right? @brandyscarney ?
There was a problem hiding this comment.
@manucorporat Yes, TMK it is only used in Sass variable declarations.
|
Snapshot comparison with master: http://ionic-snapshot-go.appspot.com/ionic2/snapshots/rrn/fw0/chrome_400x800#a2f6e0cd Looks great! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fixed rest of bad text alignments
Ionic Version: 3.x