fix(rtl): change item reorder offset for RTL #11395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AmitMY thanks a lot! |
|
@AmitMY this also need reverse transition of the reorder button to make it come from left to right now it's coming from right to left so it's coming almost from the center of item |
|
@alaa-alshamy Gestures and transitions support will come sometime soon. Currently mostly working on UI. |
|
@AmitMY ok np i can, but should i make new one? because it's actually related with this pull request |
|
Because this was already merged, yes, a new one |
|
ok i will as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Item reordering is incorrect in RTL
Changes proposed in this pull request:
Ionic Version: 3.x
Fixes: #11211