-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): allow overriding variables #11779
Conversation
Nice work on that! Sorry I missed those. @brandyscarney Looks good to me, they didn't miss any variable I changed |
Thanks for the PR! We can discuss a solution for testing @AmitMY. :) |
Short description of what this resolves:
Missing
!default
on the latest rtl compatible variables introduced by a30379b.These were the cases I could find, I might have missed some. Maybe it's possible to add a test that checks if all Ionic variables have a
!default
?PS: please squash these commits 😬
Ionic Version: 3.3.0