Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): allow overriding variables #11779

Merged
merged 19 commits into from
May 26, 2017
Merged

Conversation

Manduro
Copy link
Contributor

@Manduro Manduro commented May 24, 2017

Short description of what this resolves:

Missing !default on the latest rtl compatible variables introduced by a30379b.

These were the cases I could find, I might have missed some. Maybe it's possible to add a test that checks if all Ionic variables have a !default?

PS: please squash these commits 😬

Ionic Version: 3.3.0

@Manduro Manduro changed the title fix(card): allow overriding variables fix(): allow overriding variables May 24, 2017
@AmitMY
Copy link
Contributor

AmitMY commented May 26, 2017

Nice work on that! Sorry I missed those.
For future reference - (?!.*?( \!default))^\$.*\; (on all scss files) finds all variables set without !default

@brandyscarney Looks good to me, they didn't miss any variable I changed
What do you think about adding a test, using regex and perhaps an "ignore" rule for the ignored variables like version and paths?

@brandyscarney brandyscarney merged commit f14d7d6 into ionic-team:master May 26, 2017
@brandyscarney
Copy link
Member

Thanks for the PR! We can discuss a solution for testing @AmitMY. :)

@Manduro Manduro deleted the patch-1 branch May 26, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants