Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 ion-grid feature request - additional percentages (45%) #7508

Closed
alexbainbridge opened this issue Aug 1, 2016 · 4 comments · Fixed by #10485
Closed

v2 ion-grid feature request - additional percentages (45%) #7508

alexbainbridge opened this issue Aug 1, 2016 · 4 comments · Fixed by #10485
Milestone

Comments

@alexbainbridge
Copy link

Short description of the problem:

I appreciate that one can create new grid percentages in the CSS, however here is a suggestion for a new default one - 45%

33 > 50 is a large gap, and I often need to do something in between

What behavior are you expecting?

Its Ok at the moment, could be GREAT !

[Not massive high priority or a bug, but if you are looking to add some final sheen, this is one]

Which Ionic Version? 1.x or 2.x
2

@Ionitron Ionitron added the v2 label Aug 1, 2016
@jgw96 jgw96 added feature and removed feature labels Aug 2, 2016
brandyscarney added a commit that referenced this issue Feb 14, 2017
brandyscarney added a commit that referenced this issue Feb 14, 2017
brandyscarney added a commit that referenced this issue Feb 14, 2017
@brandyscarney
Copy link
Member

Thanks for the issue! I have been working on a new grid system based on Bootstrap 4. Here is a stand alone example of it: grid.zip

I've released a nightly if you'd like to try it out, using this nightly should still work with the old system:

npm install --save ionic-angular@2.0.1-201702142221

And here is a document (a work in progress) where I have written up some information on it: Ionic Grid API

The old grid system will eventually go away, but for now it should still work. If you see your current grid completely break or if you have feedback on the new system please let me know. Thanks! :)

@alexbainbridge
Copy link
Author

Hi Brandy
You are great!

On the existing system I had to add within my own CSS

ion-col[width-50], ion-col[width-20], ion-col[width-33] {
  margin-bottom: 0px !important;
}

to my css, as if you have two columns, that move to 1 column when responsive, the bottom margin is not equal and the spacing looks odd.

I will check that specifically on the new concept when I test

Where would you like feedback on the new?

Thanks!

@brandyscarney
Copy link
Member

@alexbainbridge Thanks! You can either post the feedback here or email me at: brandy@ionic.io 😄

@brandyscarney brandyscarney added this to the 2.1.0 milestone Feb 21, 2017
brandyscarney added a commit that referenced this issue Feb 21, 2017
…0485)

The old grid is still supported but will be deprecated in the future.

closes #6050 closes #7508
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants