-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side menu with header: scroll container extends below viewport #8504
Milestone
Comments
+1 |
@Manduro sometimes an image (or gif) worth a thousand words ;) can you provide a screenshot? It will help me understand better what I have to find. Thanks! |
Thanks @Manduro. I was able to reproduce, issue accepted. Working in a fix |
@manucorporat Cool, thanks! Is a Plunker that works for RC0 on the roadmap? That would make it a lot easier to report bugs. |
manucorporat
added a commit
to manucorporat/ionic
that referenced
this issue
Oct 5, 2016
manucorporat
added a commit
to manucorporat/ionic
that referenced
this issue
Oct 5, 2016
@manucorporat Looks great! |
manucorporat
added a commit
to manucorporat/ionic
that referenced
this issue
Oct 8, 2016
manucorporat
added a commit
to manucorporat/ionic
that referenced
this issue
Oct 8, 2016
adamdbradley
pushed a commit
that referenced
this issue
Oct 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Short description of the problem:
When using a side menu with a header, the scroll container is extending below the viewport by the height of the header. This makes the bottom content inaccessible.
For example, when the viewport height is 568px and the header height is 44px: the content starts below the header but is also 568px in height, while it should be 524px.
Or, to make it behave the same as in a normal page: the content should start behind the header and be 568px in height, but the
<div class="scroll-content">
should get amargin-top: 44px
. (What happens here.)This happens only in Safari, both desktop and mobile, both in ios and md mode. Chrome seems to prevent this by keeping the scrolling part inside the viewport automatically.
Steps to reproduce:
Workaround
Adding the following styles fixes this for me, but the margin-top should probably be set dynamically depending on the number of toolbars, tabs, etc, just as is done on a normal page.
Which Ionic Version?
2.0.0-rc.0
Plunker that shows an example of your issue
Haven't seen a Plunker for RC.0 yet.
Run
ionic info
from terminal/cmd prompt: (paste output below)The text was updated successfully, but these errors were encountered: