Disabled input fix #9676
Merged
Disabled input fix #9676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,10 @@ ion-textarea { | |||
| width: 100%; | |||
| } | |||
|
|
|||
| ion-input[disabled] .input-cover { | |||
There was a problem hiding this comment.
Can you move the rule so it is with the other rule related to input cover: https://github.com/driftyco/ionic/blob/master/src/components/input/input.scss#L77-L94
you could add it after that rule and add a sentence in the description saying the input cover shouldn't be clickable when the input is disabled.
Otherwise it looks good, just make sure there is one line break between selectors and two before a header. :)
There was a problem hiding this comment.
Below commit takes care of this, thanks for reviewing (:
|
👍 |
|
🎉 |
adamdbradley
pushed a commit
that referenced
this pull request
Dec 19, 2016
|
Why add disabled is invalid for input? |
|
Why add disabled is invalid for ion- input? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Stops disabled inputs from acting like they have been focused
Changes proposed in this pull request:
.input-coverfrom being focusedIonic Version: 2
Fixes: #9070